Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

real cancel for insertRef dialog #3240

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Conversation

octaeder
Copy link
Contributor

@octaeder octaeder commented Aug 2, 2023

This PR resolves #3230. Cancel button now quits the dialog without any effect.
First entry in the list of labels is a surrogate that allows inserting \ref{} (empty command argument) into the document.

Note: When the dialog is presented you can immediately (at least on windows)

  • scroll through the list with the up/down arrow keys
  • open the list with Alt+down arrow key (image to the right)
  • insert \ref{} by pressing Enter or clicking OK button

image

@sunderme
Copy link
Member

sunderme commented Aug 3, 2023

Could we change it to <empty> ?

@sunderme sunderme merged commit 93607e2 into texstudio-org:master Aug 4, 2023
6 checks passed
@sunderme
Copy link
Member

sunderme commented Aug 4, 2023

Thanks

@octaeder octaeder deleted the insertRef branch August 4, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior of the Cancel button of the Ref window.
2 participants